Page MenuHomePhabricator

Added check for malloc return
ClosedPublic

Authored by vhscampos on Nov 4 2016, 5:04 PM.

Details

Summary

This malloc() didn't have a check for successfully allocated memory. I created one following other examples.

Diff Detail

Repository
rL LLVM

Event Timeline

vhscampos updated this revision to Diff 76956.Nov 4 2016, 5:04 PM
vhscampos retitled this revision from to Added check for malloc return.
vhscampos updated this object.
vhscampos added reviewers: jcownie, jlpeyton, sfantao.
vhscampos added a subscriber: openmp-commits.
AndreyChurbanov accepted this revision.Nov 8 2016, 10:44 AM
AndreyChurbanov added a reviewer: AndreyChurbanov.
AndreyChurbanov added a subscriber: AndreyChurbanov.

LGTM

runtime/src/kmp_i18n.c
839 ↗(On Diff #76956)

Please add same check here as well.

This revision is now accepted and ready to land.Nov 8 2016, 10:44 AM
vhscampos updated this revision to Diff 77298.Nov 8 2016, 5:45 PM
vhscampos edited edge metadata.
vhscampos marked an inline comment as done.

Done.

Victor,
Shall I commit the changes on your behalf?

This revision was automatically updated to reflect the committed changes.