This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Replace _LIBCPP_STD_VER with TEST_STD_VER.
ClosedPublic

Authored by STL_MSFT on Nov 3 2016, 6:58 PM.

Details

Summary

This replaces every occurrence of _LIBCPP_STD_VER in the tests with TEST_STD_VER. Additionally, for every affected file, #include "test_macros.h" is being added explicitly if it wasn't already there.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 76905.Nov 3 2016, 6:58 PM
STL_MSFT retitled this revision from to [libcxx] [test] Replace _LIBCPP_STD_VER with TEST_STD_VER..
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Nov 4 2016, 12:56 PM
EricWF edited edge metadata.

LGTM. Holy crap. Thanks STL!

Just a note _LIBCPP_STD_VER is set to 11 in C++03 mode, it's silly but that's the way it is. So that makes me wonder if some of the _LIBCPP_STD_VER > 11 really should be TEST_STD_VER >= 11, since they may have just been disabling the test in C++03. Either way this preserves the status quo.

This revision is now accepted and ready to land.Nov 4 2016, 12:56 PM
STL_MSFT closed this revision.Nov 4 2016, 1:46 PM

Committed as r286007.