This is an archive of the discontinued LLVM Phabricator instance.

[llvm] FIx if-clause -Wmisleading-indentation issue.
ClosedPublic

Authored by omtcyfz on Nov 1 2016, 10:41 AM.

Details

Summary

While bootstrapping Clang with recent gcc 6.2.0 I found a bug related to misleading indentation.

I believe, a pair of {} was forgotten, especially given the above similar piece of code:

if (!RDef || !HII->isPredicable(*RDef)) {
  Done = coalesceRegisters(RD, RegisterRef(S1));
  if (Done) {
    UpdRegs.insert(RD.Reg);
    UpdRegs.insert(S1.getReg());
  }
}

Diff Detail

Repository
rL LLVM

Event Timeline

omtcyfz updated this revision to Diff 76594.Nov 1 2016, 10:41 AM
omtcyfz retitled this revision from to [llvm] FIx if-clause -Wmisleading-indentation issue..
omtcyfz updated this object.
omtcyfz added reviewers: alexfh, bkramer.
omtcyfz updated this object.
omtcyfz added a subscriber: llvm-commits.
kparzysz accepted this revision.Nov 1 2016, 12:05 PM
kparzysz edited edge metadata.

Indeed. Thanks!

This revision is now accepted and ready to land.Nov 1 2016, 12:05 PM
This revision was automatically updated to reflect the committed changes.