This is an archive of the discontinued LLVM Phabricator instance.

[LLD][PPC] Implement R_PPC_ADDR32
ClosedPublic

Authored by jackoalan on Oct 31 2016, 11:02 PM.

Details

Reviewers
ruiu
Summary

PPC 32-bit absolute pointer relocation implementation

Diff Detail

Event Timeline

jackoalan updated this revision to Diff 76523.Oct 31 2016, 11:02 PM
jackoalan retitled this revision from to [LLD][PPC] Add ADDR32 test.
jackoalan updated this object.
jackoalan added a reviewer: ruiu.
jackoalan added a subscriber: lld.
ruiu edited edge metadata.Oct 31 2016, 11:10 PM

I didn't realize that the previous patch included the implementation of ADDR32 relocation because the title of the patch only says that it implemented REL24 and RE32. Please remove ADDR32 implementation from the previous patch and add to this patch, and change the title of this patch "Implement R_PPC_ADDR32."

jackoalan updated this revision to Diff 76525.Oct 31 2016, 11:19 PM
jackoalan edited edge metadata.

Commit R_PPC_ADDR32 implementation in tandem with test

jackoalan retitled this revision from [LLD][PPC] Add ADDR32 test to [LLD][PPC] Implement R_PPC_ADDR32.Oct 31 2016, 11:19 PM
jackoalan updated this object.
ruiu accepted this revision.Nov 1 2016, 10:16 AM
ruiu edited edge metadata.

LGTM. Please go ahead and commit.

This revision is now accepted and ready to land.Nov 1 2016, 10:16 AM
ruiu closed this revision.Nov 1 2016, 11:40 AM

Committed as r285720.