[modules] Mark deleted functions as implicitly inline to allow merging

[EricWF]

Summary

When merging definitions with ModulesLocalVisibility enabled it's important to make deleted definitions implicitly inline, otherwise they'll be diagnosed as a redefinition.

[EricWF]

Add test case.

[rsmith]

lib/Sema/SemaDeclCXX.cpp

13875–13876 ↗

(On Diff #76384)

This comment is effectively saying "Modules relies on the AST being correct". I don't think we need it.

cfe/trunk/lib/Sema/SemaDeclCXX.cpp

if (IssuedDiagnostic && MD->isDefaulted())
                                 /*Diagnose*/true);
   }
 
   // C++11 [basic.start.main]p3:
   //   A program that defines main as deleted [...] is ill-formed.
   if (Fn->isMain())
     Diag(DelLoc, diag::err_deleted_main);
 
+  // C++11 [dcl.fct.def.delete]p4:
+  //  A deleted function is implicitly inline.
+  Fn->setImplicitlyInline();
   Fn->setDeletedAsWritten();
 }
 
 void Sema::SetDeclDefaulted(Decl *Dcl, SourceLocation DefaultLoc) {
   CXXMethodDecl *MD = dyn_cast_or_null<CXXMethodDecl>(Dcl);
 
   if (MD) {
     if (MD->getParent()->isDependentType()) {

cfe/trunk/test/Modules/Inputs/merge-decl-context/a.h

 
 inline A<int> ff(int i) {
   return fff<A<int>>(&i);
 }
 
 struct Aggregate {
   int member;
 };
+bool operator==(Aggregate, Aggregate) = delete;
 
 #endif