This is an archive of the discontinued LLVM Phabricator instance.

Fix uninitialized access in MachineBlockPlacement.
ClosedPublic

Authored by sammccall on Oct 28 2016, 5:24 AM.

Details

Summary

Currently PreferredLoopExit is set only in buildLoopChains, which is
never called if there are no MachineLoops.

MSan is currently broken by this:
http://lab.llvm.org:8011/builders/sanitizer-x86_64-linux-fast/builds/145/steps/check-llvm%20msan/logs/stdio

This is a naive fix to get things green again. iteratee: you may have a better fix.

This change will also mean PreferredLoopExit will not carry over if
buildCFGChains() is called a second time in runOnMachineFunction, this
appears to be the right thing.

Diff Detail

Repository
rL LLVM

Event Timeline

sammccall updated this revision to Diff 76179.Oct 28 2016, 5:24 AM
sammccall retitled this revision from to Fix uninitialized access in MachineBlockPlacement..
sammccall updated this object.
sammccall added reviewers: bkramer, iteratee.
sammccall added a subscriber: llvm-commits.
This revision was automatically updated to reflect the committed changes.