This is an archive of the discontinued LLVM Phabricator instance.

Differential D26024

[Xray] Don't generate output for xray tests
ClosedPublic

Authored by sammccall on Oct 27 2016, 1:31 AM.

Details

Reviewers
dberris
bkramer
Commits
rG9d61e14771e5: [Xray] Don't generate output for xray tests
rC285276: [Xray] Don't generate output for xray tests
rL285276: [Xray] Don't generate output for xray tests
Summary

Don't generate output for xray tests

Diff Detail

Repository
rL LLVM

Event Timeline

sammccall updated this revision to Diff 75991.Oct 27 2016, 1:31 AM
sammccall retitled this revision from to [Xray] Don't generate output for xray tests.
sammccall updated this object.
sammccall added a reviewer: dberris.
sammccall added a subscriber: cfe-commits.
sammccall added a reviewer: bkramer.Oct 27 2016, 1:49 AM
bkramer accepted this revision.Oct 27 2016, 1:51 AM
bkramer edited edge metadata.

Testing the code generator in a Driver test is a really weird thing to do. The patch doesn't make it worse though and spamming the test directory is a bad thing. I'll land this.

This revision is now accepted and ready to land.Oct 27 2016, 1:51 AM
dberris accepted this revision.Oct 27 2016, 1:53 AM
dberris edited edge metadata.

Yes, thanks (and sorry for missing this).

Closed by commit rL285276: [Xray] Don't generate output for xray tests (authored by d0k). · Explain WhyOct 27 2016, 1:58 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
cfe/
trunk/
test/
Driver/
XRay/
2 lines
2 lines

Diff 75994

cfe/trunk/test/Driver/XRay/xray-instrument-cpu.c

// RUN: not %clang -v -fxray-instrument -c %s // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
// XFAIL: amd64-, x86_64-, x86_64h-, arm // XFAIL: amd64-, x86_64-, x86_64h-, arm
// REQUIRES: linux // REQUIRES: linux
typedef int a; typedef int a;

cfe/trunk/test/Driver/XRay/xray-instrument-os.c

// RUN: not %clang -v -fxray-instrument -c %s // RUN: not %clang -o /dev/null -v -fxray-instrument -c %s
// XFAIL: -linux- // XFAIL: -linux-
// REQUIRES-ANY: amd64, x86_64, x86_64h, arm // REQUIRES-ANY: amd64, x86_64, x86_64h, arm
typedef int a; typedef int a;