[libc++] Cleanup non-portable std::any tests

[CaseyCarter]

Summary

Cleanup nonportable behavior in tests for std::any

Fixes MS issues 63, 64, and 65.

test/std/utilities/any/any.class/any.cons/move.pass.cpp:

• "Moves are always destructive" is not a portable assumption; check with LIBCPP_ASSERT.

test/std/utilities/any/any.class/any.cons/value.pass.cpp:
test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp:

• The standard does not forbid initializing std::any from any pointer-to-function type. The DecayTag test is a libc++ extension (at best); factor it out into a test in the libcxx hierarchy.

test/std/utilities/any/any.class/any.modifiers/swap.pass.cpp:

• Self-swap is not specified to perform no moves; check with LIBCPP_ASSERT.

[CaseyCarter]

test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp

36 ↗

(On Diff #75934)

I'm generously calling this a "libc++ extension." From my interpretation of N4606, LWG2744, and LWG2754, this appears to be a bug.

[EricWF]

test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp

1 ↗

(On Diff #75934)

Just kill this test entirely. I'm going to change the behavior shortly.

[CaseyCarter]

Cleanup nonportable behavior in tests for std::any

Fixes MS issues 63, 64, and 65.

test/std/utilities/any/any.class/any.cons/move.pass.cpp:

• "Moves are always destructive" is not a portable assumption; check with LIBCPP_ASSERT.

test/std/utilities/any/any.class/any.cons/value.pass.cpp:

• The standard does not forbid initializing std::any from any pointer-to-function type. Remove the non-conforming DecayTag test.

test/std/utilities/any/any.class/any.modifiers/swap.pass.cpp:

• Self-swap is not specified to perform no moves; check with LIBCPP_ASSERT.

[CaseyCarter]

DecayTag destroyed.

[EricWF]

test/libcxx/utilities/any/any.class/any.cons/value.pass.cpp

36 ↗

(On Diff #75934)

I agree. I want this to be a diagnostic of some sort. Preferably a static warning because if you've managed to decay the tags your in for a treat.

libcxx/trunk/test/std/utilities/any/any.class/any.cons/move.pass.cpp

Type::reset();
         // Moving should not perform allocations since it must be noexcept.
         DisableAllocationGuard g; ((void)g);
 
         any a2(std::move(a));
 
         assert(Type::moved == 1 || Type::moved == 2); // zero or more move operations can be performed.
         assert(Type::copied == 0); // no copies can be performed.
         assert(Type::count == 1 + a.has_value());
-        assertEmpty(a); // Moves are always destructive.
         assertContains<Type>(a2, 42);
+        LIBCPP_ASSERT(!a.has_value()); // Moves are always destructive.
         if (a.has_value())
             assertContains<Type>(a, 0);
     }
     assert(Type::count == 0);
 }
 
 int main()
 {

libcxx/trunk/test/std/utilities/any/any.class/any.cons/value.pass.cpp

OKTag ot = std::in_place;
         assertContains<OKDecay>(a, ot);
     }
     {
         struct Dummy { Dummy() = delete; };
         using T = std::in_place_type_t<Dummy>;
         static_assert(!std::is_constructible<std::any, T>::value, "");
     }
     {
-        using DecayTag = std::decay_t<BadTag>;
-        static_assert(!std::is_constructible<std::any, DecayTag>::value, "");
-    }
-    {
         // Test that the ValueType&& constructor SFINAE's away when the
         // argument is non-copyable
         struct NoCopy {
           NoCopy() = default;
           NoCopy(NoCopy const&) = delete;
           NoCopy(int) {}
         };
         static_assert(!std::is_constructible<std::any, NoCopy>::value, "");
         static_assert(!std::is_constructible<std::any, NoCopy&>::value, "");
         static_assert(!std::is_convertible<NoCopy, std::any>::value, "");
     }
 }
 
 int main() {
     test_copy_move_value<small>();
     test_copy_move_value<large>();
     test_copy_value_throws<small_throws_on_copy>();
     test_copy_value_throws<large_throws_on_copy>();
     test_move_value_throws();
     test_sfinae_constraints();
 }
 No newline at end of file

libcxx/trunk/test/std/utilities/any/any.class/any.modifiers/swap.pass.cpp

void test_self_swap() {
     { // small
         using T = small;
         any a{T{42}};
         T::reset();
         a.swap(a);
         assertContains<T>(a, 42);
         assert(T::count == 1);
         assert(T::copied == 0);
-        assert(T::moved == 0);
+        LIBCPP_ASSERT(T::moved == 0);
     }
     assert(small::count == 0);
     { // large
         using T = large;
         any a{T{42}};
         T::reset();
         a.swap(a);
         assertContains<T>(a, 42);
-        assert(T::copied == 0);
-        assert(T::moved == 0);
         assert(T::count == 1);
+        assert(T::copied == 0);
+        LIBCPP_ASSERT(T::moved == 0);
     }
     assert(large::count == 0);
 }
 
 int main()
 {
     test_noexcept();
     test_swap_empty<small>();
     test_swap_empty<large>();
     test_swap<small1, small2>();
     test_swap<large1, large2>();
     test_swap<small, large>();
     test_swap<large, small>();
     test_self_swap();
 }