Avoid running regex on None

[azharudd]

Summary

We are attempting to run regex on version_ln even if it is None. This can cause TypeError.

Patch by Azharuddin Mohammed

[azharudd]

lnt/testing/util/compilers.py

85 ↗

(On Diff #75792)

this is the faulty line.

[azharudd]

Chris, can you please commit this change. I do not have commit rights yet. Thanks.

lnt/trunk/lnt/testing/util/compilers.py

for ln in cc_version.split('\n'):
             if not m:
                 fatal("unable to determine cc1 binary: %r: %r" % (cc, ln))
             cc1_binary, = m.groups()
         elif "-_Amachine" in ln:
             m = re.match(r'([^ ]*) *-.*', ln)
             if not m:
                 fatal("unable to determine cc1 binary: %r: %r" % (cc, ln))
             cc1_binary, = m.groups()
+    if cc1_binary is None:
+        error("unable to find compiler cc1 binary: %r: %r" % (cc, cc_version))
     if version_ln is None:
         error("unable to find compiler version: %r: %r" % (cc, cc_version))
-    if cc1_binary is None:
-        error("unable to find compiler cc1 binary: %r: %r" % (
-                cc, cc_version))
+    else:
         m = re.match(r'(.*) version ([^ ]*) +(\([^(]*\))(.*)', version_ln)
         if m is not None:
             cc_name,cc_version_num,cc_build_string,cc_extra = m.groups()
         else:
             # If that didn't match, try a more basic pattern.
             m = re.match(r'(.*) version ([^ ]*)', version_ln)
             if m is not None:
                 cc_name,cc_version_num = m.groups()
                 cc_build_string = cc_extra = ""
             else:
                 error("unable to determine compiler version: %r: %r" % (
                         cc, version_ln))
                 cc_name = "unknown"
                 cc_version_num = cc_build_string = cc_extra = ""
 
     # Compute normalized compiler name and type. We try to grab source
     # revisions, branches, and tags when possible.
     cc_norm_name = None
     cc_build = None
     cc_src_branch = cc_alt_src_branch = None
     cc_src_revision = cc_alt_src_revision = None
     cc_src_tag = None