Page MenuHomePhabricator

Avoid running regex on None
ClosedPublic

Authored by azharudd on Oct 25 2016, 2:29 PM.

Details

Summary

We are attempting to run regex on version_ln even if it is None. This can cause TypeError.

Patch by Azharuddin Mohammed

Diff Detail

Repository
rL LLVM

Event Timeline

azharudd updated this revision to Diff 75792.Oct 25 2016, 2:29 PM
azharudd retitled this revision from to Avoid running regex on None.
azharudd updated this object.
azharudd added a reviewer: cmatthews.
azharudd set the repository for this revision to rL LLVM.
azharudd added a subscriber: llvm-commits.
azharudd added inline comments.Oct 25 2016, 2:33 PM
lnt/testing/util/compilers.py
85 ↗(On Diff #75792)

this is the faulty line.

cmatthews accepted this revision.Oct 25 2016, 3:04 PM
cmatthews edited edge metadata.
This revision is now accepted and ready to land.Oct 25 2016, 3:04 PM

Chris, can you please commit this change. I do not have commit rights yet. Thanks.

This revision was automatically updated to reflect the committed changes.