This is an archive of the discontinued LLVM Phabricator instance.

Include full filename range for missing includes
ClosedPublic

Authored by erikjv on Oct 21 2016, 7:28 AM.

Reviewers

klimek
bkramer

Summary

For the purpose of highlighting in an IDE.

erikjv retitled this revision from to Include full filename range for missing includes.

erikjv updated this object.

erikjv added reviewers: bkramer, klimek.

erikjv added a subscriber: cfe-commits.

This revision is now accepted and ready to land.Oct 21 2016, 7:34 AM

r285057

Path

Size

lib/

Lex/

3 lines

test/

Preprocessor/

8 lines

Show First 20 Lines • Show All 1,841 Lines • ▼ Show 20 Lines	if (!SuppressIncludeNotFoundError) {
Diag(FilenameTok, diag::err_pp_file_not_found_not_fatal) <<		Diag(FilenameTok, diag::err_pp_file_not_found_not_fatal) <<
Filename <<		Filename <<
FixItHint::CreateReplacement(Range, "\"" + Filename.str() + "\"");		FixItHint::CreateReplacement(Range, "\"" + Filename.str() + "\"");
}		}
}		}

// If the file is still not found, just go with the vanilla diagnostic		// If the file is still not found, just go with the vanilla diagnostic
if (!File)		if (!File)
Diag(FilenameTok, diag::err_pp_file_not_found) << Filename;		Diag(FilenameTok, diag::err_pp_file_not_found) << Filename
		<< FilenameRange;
}		}
}		}

// Should we enter the source file? Set to false if either the source file is		// Should we enter the source file? Set to false if either the source file is
// known to have no effect beyond its effect on module visibility -- that is,		// known to have no effect beyond its effect on module visibility -- that is,
// if it's got an include guard that is already defined or is a modular header		// if it's got an include guard that is already defined or is a modular header
// we've imported or already built.		// we've imported or already built.
bool ShouldEnter = true;		bool ShouldEnter = true;
▲ Show 20 Lines • Show All 932 Lines • Show Last 20 Lines

				// RUN: env CINDEXTEST_KEEP_GOING=1 c-index-test -test-load-source all %s > /dev/null 2> %t.err
				// RUN: FileCheck < %t.err -check-prefix=CHECK-RANGE %s

				#include <foobar.h>
				#include "moozegnarf.h"

				// CHECK-RANGE: rewrite-includes-missing.c:4:10:{4:10-4:19}: fatal error: 'foobar.h' file not found
				// CHECK-RANGE: rewrite-includes-missing.c:5:10:{5:10-5:24}: fatal error: 'moozegnarf.h' file not found