This is an archive of the discontinued LLVM Phabricator instance.

Differential D25861

Remove the unused POLLY_LINK_LIBS for linking polly into tools
ClosedPublic

Authored by etherzhhb on Oct 20 2016, 6:56 PM.

Details

Reviewers
Meinersbur
Group Reviewers
Restricted Project

Diff Detail

Repository
rL LLVM

Event Timeline

etherzhhb updated this revision to Diff 75386.Oct 20 2016, 6:56 PM
etherzhhb retitled this revision from to Remove the unused POLLY_LINK_LIBS for linking polly into tools.
etherzhhb updated this object.
etherzhhb added reviewers: Meinersbur, Restricted Project.
etherzhhb set the repository for this revision to rL LLVM.
Herald added subscribers: mgorny, beanz. · View Herald TranscriptOct 20 2016, 6:56 PM
Meinersbur accepted this revision.Oct 21 2016, 4:15 AM
Meinersbur edited edge metadata.

Are you going to review the removal of POLLY_LINK_LIBS in polly and clang separately?

This revision is now accepted and ready to land.Oct 21 2016, 4:15 AM
etherzhhb added a comment.Oct 21 2016, 8:19 AM
In D25861#576306, @Meinersbur wrote:

Are you going to review the removal of POLLY_LINK_LIBS in polly and clang separately?

Yes, I want to first remove all users of POLLY_LINK_LIBS, then remove it from Polly

etherzhhb closed this revision.Oct 29 2016, 11:55 PM

This is pushed, phabricator didn't update this patch's status

Revision Contents

PathSize
tools/
bugpoint/
5 lines
opt/
5 lines

Diff 75386

tools/bugpoint/CMakeLists.txt

Show All 28 Linesadd_llvm_tool(bugpoint
OptimizerDriver.cpp OptimizerDriver.cpp
ToolRunner.cpp ToolRunner.cpp
bugpoint.cpp bugpoint.cpp
) )
export_executable_symbols(bugpoint) export_executable_symbols(bugpoint)
if(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) if(WITH_POLLY AND LINK_POLLY_INTO_TOOLS)
target_link_libraries(bugpoint Polly) target_link_libraries(bugpoint Polly)
if(POLLY_LINK_LIBS)
foreach(lib ${POLLY_LINK_LIBS})
target_link_libraries(bugpoint ${lib})
endforeach(lib)
endif(POLLY_LINK_LIBS)
# Ensure LLVMTarget can resolve dependences in Polly. # Ensure LLVMTarget can resolve dependences in Polly.
target_link_libraries(bugpoint LLVMTarget) target_link_libraries(bugpoint LLVMTarget)
endif(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) endif(WITH_POLLY AND LINK_POLLY_INTO_TOOLS)

tools/opt/CMakeLists.txt

Show All 29 Linesadd_llvm_tool(opt
PassPrinters.cpp PassPrinters.cpp
PrintSCC.cpp PrintSCC.cpp
opt.cpp opt.cpp
) )
export_executable_symbols(opt) export_executable_symbols(opt)
if(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) if(WITH_POLLY AND LINK_POLLY_INTO_TOOLS)
target_link_libraries(opt Polly) target_link_libraries(opt Polly)
if(POLLY_LINK_LIBS)
foreach(lib ${POLLY_LINK_LIBS})
target_link_libraries(opt ${lib})
endforeach(lib)
endif(POLLY_LINK_LIBS)
endif(WITH_POLLY AND LINK_POLLY_INTO_TOOLS) endif(WITH_POLLY AND LINK_POLLY_INTO_TOOLS)