This is an archive of the discontinued LLVM Phabricator instance.

[MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64
ClosedPublic

Authored by slthakur on Oct 19 2016, 10:48 PM.

Details

Reviewers
eugenis
Summary

Changed the kernel sigaction structure in test syscalls_sigaction.cc for MIPS according to the structure defined in kernel.

Diff Detail

Repository
rL LLVM

Event Timeline

slthakur updated this revision to Diff 75267.Oct 19 2016, 10:48 PM
slthakur retitled this revision from to [MSAN][MIPS] Fix test Linux/syscalls_sigaction.cc on mips64.
slthakur updated this object.
slthakur added a reviewer: eugenis.
slthakur set the repository for this revision to rL LLVM.
slthakur added subscribers: jaydeep, llvm-commits.
eugenis added inline comments.Oct 20 2016, 12:51 PM
test/msan/Linux/syscalls_sigaction.cc
21

Are you sure that restorer follows mask? Length of the mask field (20 here) does not match any kernel definition - it is simply large enough to avoid out-of-bounds access.

The kernel definition does not seem to have a restorer field at all.

slthakur updated this revision to Diff 77012.Nov 6 2016, 10:39 PM
slthakur removed rL LLVM as the repository for this revision.

Removed the restorer field from the kernel sigaction structure for MIPS.

test/msan/Linux/syscalls_sigaction.cc
21

Yes you are right, the sigaction structure for MIPS does not have a restorer field.

slthakur set the repository for this revision to rL LLVM.Nov 6 2016, 10:40 PM
eugenis accepted this revision.Nov 7 2016, 11:20 AM
eugenis edited edge metadata.

LGTM

This revision is now accepted and ready to land.Nov 7 2016, 11:20 AM
slthakur closed this revision.Nov 11 2016, 4:15 AM

Committed revision 286583