[CMake] Rename lldb-launcher to darwin-debug

[beanz]

Summary

This tool is only built on Darwin, and the name darwin-debug matches the Xcode project. We should have this in sync unless there is a good reason not to.

[tfiala]

This seems fine, but @labath might want to weigh in if Android tools have a hard-baked assumption anywhere on lldb-launcher.

[labath]

I have no idea what this executable does, but I am pretty sure we don't use it.

PS: there are some mentions of this in the scripts/Python/finishSwigPythonLLDB.py script. Does that need an update?

[beanz]

Cleaning up extra references to lldb-launcher

lldb/trunk/scripts/Python/finish-swig-Python-LLDB.sh

then
 
     if [ ! -L "${framework_python_dir}/darwin-debug" ]
     then
         if [ $Debug -eq 1 ]
         then
             echo "Creating symlink for darwin-debug"
         fi
         cd "${framework_python_dir}"
-        ln -s "../../../../bin/lldb-launcher" darwin-debug
     else
         if [ $Debug -eq 1 ]
         then
             echo "${framework_python_dir}/darwin-debug already exists."
         fi
     fi
 fi
 

lldb/trunk/scripts/Python/finishSwigPythonLLDB.py

else:
             strSrc = os.path.join(vstrLldbLibDir, "liblldb" + strLibFileExtn)
 
     bOk, strErrMsg = make_symlink(
         vDictArgs, vstrFrameworkPythonDir, strSrc, strTarget)
 
     return (bOk, strErrMsg)
 
 #++---------------------------------------------------------------------------
-# Details:  Make the symbolic link to the darwin-debug.
-# Args:     vDictArgs               - (R) Program input parameters.
-#           vstrFrameworkPythonDir  - (R) Python framework directory.
-#           vstrDarwinDebugFileName - (R) File name for darwin-debug.
-# Returns:  Bool - True = function success, False = failure.
-#           Str - Error description on task failure.
-# Throws:   None.
-#--
-
-
-def make_symlink_darwin_debug(
-        vDictArgs,
-        vstrFrameworkPythonDir,
-        vstrDarwinDebugFileName):
-    dbg = utilsDebug.CDebugFnVerbose(
-        "Python script make_symlink_darwin_debug()")
-    bOk = True
-    strErrMsg = ""
-    strTarget = vstrDarwinDebugFileName
-    strSrc = ""
-
-    bMakeFileCalled = "-m" in vDictArgs
-    if not bMakeFileCalled:
-        return (bOk, strErrMsg)
-    else:
-        strSrc = os.path.join("bin", "lldb-launcher")
-
-    bOk, strErrMsg = make_symlink(
-        vDictArgs, vstrFrameworkPythonDir, strSrc, strTarget)
-
-    return (bOk, strErrMsg)
-
-#++---------------------------------------------------------------------------
 # Details:  Make the symbolic link to the lldb-argdumper.
 # Args:     vDictArgs               - (R) Program input parameters.
 #           vstrFrameworkPythonDir  - (R) Python framework directory.
 #           vstrArgdumperFileName   - (R) File name for lldb-argdumper.
 # Returns:  Bool - True = function success, False = failure.
 #           Str - Error description on task failure.
 # Throws:   None.
 #--
def create_symlinks(vDictArgs, vstrFrameworkPythonDir, vstrLldbLibDir):
     # Make symlink for _lldb
     strLibLldbFileName = "_lldb"
     if bOk:
         bOk, strErrMsg = make_symlink_liblldb(vDictArgs,
                                               vstrFrameworkPythonDir,
                                               strLibLldbFileName,
                                               vstrLldbLibDir)
 
-    # Make symlink for darwin-debug on Darwin
-    strDarwinDebugFileName = "darwin-debug"
-    if bOk and eOSType == utilsOsType.EnumOsType.Darwin:
-        bOk, strErrMsg = make_symlink_darwin_debug(vDictArgs,
-                                                   vstrFrameworkPythonDir,
-                                                   strDarwinDebugFileName)
-
     # Make symlink for lldb-argdumper
     strArgdumperFileName = "lldb-argdumper"
     if bOk:
         bOk, strErrMsg = make_symlink_lldb_argdumper(vDictArgs,
                                                      vstrFrameworkPythonDir,
                                                      strArgdumperFileName)
 
     return (bOk, strErrMsg)

lldb/trunk/tools/darwin-debug/CMakeLists.txt

-add_lldb_executable(lldb-launcher INCLUDE_IN_FRAMEWORK
+add_lldb_executable(darwin-debug INCLUDE_IN_FRAMEWORK
   darwin-debug.cpp
   )
 
-install(TARGETS lldb-launcher
+install(TARGETS darwin-debug
   RUNTIME DESTINATION bin)