This is an archive of the discontinued LLVM Phabricator instance.

[ADT] Remove CachedHash, which is unused.
ClosedPublic

Authored by jlebar on Oct 14 2016, 11:06 AM.

Event Timeline

jlebar updated this revision to Diff 74717.Oct 14 2016, 11:06 AM
jlebar retitled this revision from to [ADT] Remove CachedHash, which is unused..
jlebar updated this object.
jlebar added a reviewer: timshen.
jlebar added a subscriber: llvm-commits.
timshen edited edge metadata.Oct 14 2016, 1:11 PM

It's used in lld/ELF/SymbolTable.h .

It's used in lld/ELF/SymbolTable.h .

Dang, you are right. I was thrown off because the lines above use CachedHashString, which is different.

This actually looks pretty reasonable, too.

I guess that does it for this patch.

jlebar abandoned this revision.Oct 14 2016, 1:14 PM
jlebar reclaimed this revision.Oct 15 2016, 3:10 PM

Reopening -- I now have the mechanisms (soon to be added as dependent patches) in place to get rid of this again.

Rafael, I've structured this removal as one clean commit so if you ever want to resurrect this class, it'll be relatively easy.

jlebar updated this revision to Diff 74776.Oct 15 2016, 3:12 PM

Rebase patch.

This revision was automatically updated to reflect the committed changes.