Page MenuHomePhabricator

[CMake] Populate LLDB.framework's headers directory
ClosedPublic

Authored by beanz on Oct 13 2016, 10:34 AM.

Details

Summary

This patch adds support for installing public headers in LLDB.framework, and symlinking the headers into the build directory.

While writing the patch I discovered a bug in CMake that prevents applying POST_BUILD steps to framework targets (https://gitlab.kitware.com/cmake/cmake/issues/16363).

I've implemented the support using POST_BUILD steps wrapped under a CMake version check with a TODO so that we can track the fix.

Diff Detail

Repository
rL LLVM

Event Timeline

beanz updated this revision to Diff 74543.Oct 13 2016, 10:34 AM
beanz retitled this revision from to [CMake] Populate LLDB.framework's headers directory.
beanz updated this object.
beanz added reviewers: tfiala, zturner, spyffe.
beanz added a subscriber: lldb-commits.

Worth noting, the CMake bug now has a fix in a pull request:

https://gitlab.kitware.com/cmake/cmake/merge_requests/172

tfiala accepted this revision.Oct 13 2016, 5:56 PM
tfiala edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Oct 13 2016, 5:56 PM
This revision was automatically updated to reflect the committed changes.