Page MenuHomePhabricator

Post commit review of changes to D18226
AbandonedPublic

Authored by iteratee on Oct 11 2016, 1:46 PM.

Details

Reviewers
davidxl
Summary

Minor fixes to D18226, together with regression tests for each issue encountered

Diff Detail

Event Timeline

iteratee updated this revision to Diff 74288.Oct 11 2016, 1:46 PM
iteratee retitled this revision from to Post commit review of changes to D18226.
iteratee updated this object.
iteratee added a reviewer: davidxl.
iteratee set the repository for this revision to rL LLVM.
iteratee added subscribers: echristo, llvm-commits.
davidxl added inline comments.Oct 14 2016, 5:23 PM
test/CodeGen/AArch64/tail-dup-repeat-worklist.ll
37

can you clean up the test case a little more?

  1. simplify variable names
  2. remove unecessary types
  3. simplify block bodies to remove unessential things.
test/CodeGen/X86/tail-dup-merge-loop-headers.ll
6

Same here -- please reduce the test case further to minimal form.

iteratee abandoned this revision.May 25 2017, 4:01 PM