__builtin_fpclassify missing one int parameter

[taniabarg]

Summary

BIF fpclassify has the wrong number of integer parameters specified in Builtins.def. There should be 5 int parameters (each representing the values FP_NAN, FP_INFINITE, FP_NORMAL, FP_SUBNORMAL and FP_ZERO) but Builtins.def previously specified 4.

[hubert.reinterpretcast]

A test should probably be added as well.

[ahatanak]

__builtin_fpclassify takes five int arguments followed by one last argument that is of floating point type. Do you know if there is a way to specify the last one argument is a floating point rather than using '.'?

[hubert.reinterpretcast]

In D25480#567552, @ahatanak wrote:

__builtin_fpclassify takes five int arguments followed by one last argument that is of floating point type. Do you know if there is a way to specify the last one argument is a floating point rather than using '.'?

There is already code in clang/lib/Sema/SemaChecking.cpp to generate diag::err_typecheck_call_invalid_unary_fp.

[taniabarg]

Added test to test/Sema/builtin-unary-fp.c that will fail without the proposed change (without the change, the test will -not- attempt to implicitly cast the 5th parameter to int).

cfe/trunk/include/clang/Basic/Builtins.def

 BUILTIN(__builtin_isgreater     , "i.", "Fnc")
 BUILTIN(__builtin_isgreaterequal, "i.", "Fnc")
 BUILTIN(__builtin_isless        , "i.", "Fnc")
 BUILTIN(__builtin_islessequal   , "i.", "Fnc")
 BUILTIN(__builtin_islessgreater , "i.", "Fnc")
 BUILTIN(__builtin_isunordered   , "i.", "Fnc")
 
 // Unary FP classification
-BUILTIN(__builtin_fpclassify, "iiiii.", "Fnc")
+BUILTIN(__builtin_fpclassify, "iiiiii.", "Fnc")
 BUILTIN(__builtin_isfinite,   "i.", "Fnc")
 BUILTIN(__builtin_isinf,      "i.", "Fnc")
 BUILTIN(__builtin_isinf_sign, "i.", "Fnc")
 BUILTIN(__builtin_isnan,      "i.", "Fnc")
 BUILTIN(__builtin_isnormal,   "i.", "Fnc")
 
 // FP signbit builtins
 BUILTIN(__builtin_signbit, "i.", "Fnc")

cfe/trunk/test/Sema/builtin-unary-fp.c

 // RUN: %clang_cc1 %s -fsyntax-only -verify -pedantic
 void check(int);
 void a() {
   check(__builtin_isfinite(1.0f));
   check(__builtin_isinf(1.0));
   check(__builtin_isinf_sign(1.0L));
   check(__builtin_isnan(1.0f));
   check(__builtin_isnormal(1.0f));
   check(__builtin_isfinite(1)); // expected-error{{requires argument of floating point type}}
   check(__builtin_isinf()); // expected-error{{too few arguments}}
   check(__builtin_isnan(1,2)); // expected-error{{too many arguments}}
   check(__builtin_fpclassify(0, 0, 0, 0, 0, 1.0));
   check(__builtin_fpclassify(0, 0, 0, 0, 0, 1)); // expected-error{{requires argument of floating point type}}
+  check(__builtin_fpclassify(0, 1, 2, 3, 4.5, 5.0)); // expected-warning{{implicit conversion from 'double' to 'int' changes value from 4.5 to 4}}
   check(__builtin_fpclassify(0, 0, 0, 0, 1)); // expected-error{{too few arguments}}
   check(__builtin_fpclassify(0, 0, 0, 0, 0, 1, 0)); // expected-error{{too many arguments}}
 }