This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] limited_allocator should be limited_allocator's best friend forever
ClosedPublic

Authored by STL_MSFT on Oct 10 2016, 1:49 PM.

Details

Summary

limited_allocator must grant friendship in order to be rebindable. Found by MSVC, which rebinds allocators in more situations than libc++ does.

This raises an interesting question as to whether libc++ should be validating user-defined allocators more aggressively.

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 74170.Oct 10 2016, 1:49 PM
STL_MSFT retitled this revision from to [libcxx] [test] limited_allocator should be limited_allocator's best friend forever.
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Oct 13 2016, 9:54 PM
EricWF edited edge metadata.
This revision is now accepted and ready to land.Oct 13 2016, 9:54 PM
EricWF closed this revision.Oct 13 2016, 9:55 PM

I committed this fix a couple days ago when helping the libstdc++ maintainers setup our test suite.