This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] Use libunwind instead of libgcc_s if libcxxabi uses it
AbandonedPublic

Authored by phosek on Oct 9 2016, 3:05 PM.

Details

Reviewers
None
Summary

When libcxxabi is configured to use LLVM unwinder, we should use it instead of always using libgcc_s.

Diff Detail

Repository
rL LLVM

Event Timeline

phosek updated this revision to Diff 74084.Oct 9 2016, 3:05 PM
phosek retitled this revision from to [libcxx] Use libunwind instead of libgcc_s if libcxxabi uses it .
phosek updated this object.
phosek set the repository for this revision to rL LLVM.
phosek added a subscriber: llvm-commits.

This is not that simple. Remember that libgcc_s serves both as unwinder and compiler runtime. Since libcxx is linked with -nodefaultlibs, including gcc_s is necessary to fulfill dependency on automatically generated runtime calls (__udiv* stuff, for example). I'm working on fixing that properly but it is stalled on D25338.

Also, your patch is based on outdated code. Please update your repository before submitting patches.

phosek abandoned this revision.Oct 10 2016, 12:16 AM

Thanks for the comment, I just rebased my change and realized that it's no longer relevant.