This is an archive of the discontinued LLVM Phabricator instance.

ThinLTO: don't perform incremental LTO on module without a hash
ClosedPublic

Authored by mehdi_amini on Oct 7 2016, 1:27 PM.

Details

Summary

Clang always emit a hash for ThinLTO, but as other frontend are
starting to use ThinLTO, this could be a serious bug.

Event Timeline

mehdi_amini updated this revision to Diff 73978.Oct 7 2016, 1:27 PM
mehdi_amini retitled this revision from to ThinLTO: don't perform incremental LTO on module without a hash.
mehdi_amini updated this object.
mehdi_amini added a reviewer: tejohnson.
mehdi_amini added a subscriber: llvm-commits.
tejohnson accepted this revision.Oct 7 2016, 4:05 PM
tejohnson edited edge metadata.

LGTM, but looks like this is on top of D25300, so I guess that one needs to go in first?

This revision is now accepted and ready to land.Oct 7 2016, 4:05 PM

It is conceptually independent and could go in now, but yes I'll wait for the other one so that I don't have to fix the conflict.

It is conceptually independent and could go in now, but yes I'll wait for the other one so that I don't have to fix the conflict.

I don't have the other approach started yet, and this is needed to be able to fix the bug fixed by D25300.

It is conceptually independent and could go in now, but yes I'll wait for the other one so that I don't have to fix the conflict.

I don't have the other approach started yet, and this is needed to be able to fix the bug fixed by D25300.

Nevermind, wrong patch! That's what happens when I try to review on my phone...

This revision was automatically updated to reflect the committed changes.