This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [test] Guard __has_include usage with a macro
ClosedPublic

Authored by STL_MSFT on Oct 4 2016, 2:20 PM.

Details

Summary

There's a macro scheme already being used for has_feature etc. Use it for has_include too, which makes MSVC happy (it doesn't support __has_include yet, and unguarded use explodes horribly).

Diff Detail

Event Timeline

STL_MSFT updated this revision to Diff 73553.Oct 4 2016, 2:20 PM
STL_MSFT retitled this revision from to [libcxx] [test] Guard __has_include usage with a macro.
STL_MSFT updated this object.
STL_MSFT added reviewers: EricWF, mclow.lists.
STL_MSFT added a subscriber: cfe-commits.
EricWF accepted this revision.Oct 4 2016, 2:33 PM
EricWF edited edge metadata.

LGTM. Although I would have thought the first half of the conjunction would have prevented MSVC's PP from seeing the __has_include.

I'll get to the rest of the patches tomorrow.

This revision is now accepted and ready to land.Oct 4 2016, 2:33 PM
EricWF closed this revision.Oct 4 2016, 2:34 PM