Details
Details
Diff Detail
Diff Detail
- Build Status
Buildable 122 Build 122: arc lint + arc unit
Event Timeline
Comment Actions
This is great!
clang-move/ClangMove.cpp | ||
---|---|---|
120–124 | Maybe: return (SM->getLocForEndOfFile(LocInfo.first) == EndLoc) ? EndLoc : EndLoc.getLocWithOffset(1); | |
408 | Looks like GetFullRange is called twice on the same Decl: one for creating insertion replacement and one for deletion replacement. This seems to be a duplicate. |
Comment Actions
Address review comments.
clang-move/ClangMove.cpp | ||
---|---|---|
408 | Good point. Yeah, currently the GetFullRange is called twice. Have added a FIXME. |
Maybe: