This is an archive of the discontinued LLVM Phabricator instance.

[WebAssembly] Add just enough block-signature support to conform to the new rules.
ClosedPublic

Authored by sunfish on Sep 30 2016, 5:25 PM.

Details

Summary

This reverts r281773 and makes LLVM emit block signatures as is now required.

Diff Detail

Repository
rL LLVM

Event Timeline

sunfish updated this revision to Diff 73170.Sep 30 2016, 5:25 PM
sunfish retitled this revision from to [WebAssembly] Add just enough block-signature support to conform to the new rules..
sunfish updated this object.
sunfish set the repository for this revision to rL LLVM.
sunfish added subscribers: dschuff, jgravelle-google.
dschuff added inline comments.Sep 30 2016, 5:34 PM
lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp
574 ↗(On Diff #73170)

Not that you have any opinions about that, or anything :D

sunfish added inline comments.Oct 3 2016, 8:39 AM
lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp
574 ↗(On Diff #73170)

Heh. Do you have any suggestions on what we can say instead? :-)

dschuff added inline comments.Oct 3 2016, 9:57 AM
lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp
486 ↗(On Diff #73170)

This could be reverse(MF)?

574 ↗(On Diff #73170)

I have no problem with opinionated and/or snarky comments as long as they are useful :) How about describing what the nature of the checks and/or what exactly we have to do? (Just so I'm clear in my own understanding, this is about the signatures for fallthrough-return blocks, right?) Speaking of, FixEndOfFunctionEnds is a little hard to parse, and in any case it fixes the block/loop and not the end, so maybe it could be called FixEndOfFunctionBlocks or FixFallthroughReturnSignatures or something like that?

This revision was automatically updated to reflect the committed changes.