This reverts r281773 and makes LLVM emit block signatures as is now required.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp | ||
---|---|---|
574 ↗ | (On Diff #73170) | Not that you have any opinions about that, or anything :D |
lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp | ||
---|---|---|
574 ↗ | (On Diff #73170) | Heh. Do you have any suggestions on what we can say instead? :-) |
lib/Target/WebAssembly/WebAssemblyCFGStackify.cpp | ||
---|---|---|
486 ↗ | (On Diff #73170) | This could be reverse(MF)? |
574 ↗ | (On Diff #73170) | I have no problem with opinionated and/or snarky comments as long as they are useful :) How about describing what the nature of the checks and/or what exactly we have to do? (Just so I'm clear in my own understanding, this is about the signatures for fallthrough-return blocks, right?) Speaking of, FixEndOfFunctionEnds is a little hard to parse, and in any case it fixes the block/loop and not the end, so maybe it could be called FixEndOfFunctionBlocks or FixFallthroughReturnSignatures or something like that? |