This is an archive of the discontinued LLVM Phabricator instance.

Differential D25133

Update clang test to accomendate discriminator change in https://reviews.llvm.org/D25132
ClosedPublic

Authored by danielcdh on Sep 30 2016, 2:47 PM.

Details

Reviewers
dnovillo
davidxl
Commits
rGe239e951609a: Update clang test to accomendate discriminator change in https://reviews.llvm.
rC283564: Update clang test to accomendate discriminator change in https://reviews.llvm.
rL283564: Update clang test to accomendate discriminator change in https://reviews.llvm.
Summary

https://reviews.llvm.org/D25132 added discriminator even add -g0. This leads to test fail which is addressed in thie patch.

Diff Detail

Event Timeline

danielcdh updated this revision to Diff 73149.Sep 30 2016, 2:47 PM
danielcdh retitled this revision from to Update clang test to accomendate discriminator change in https://reviews.llvm.org/D25132.
danielcdh updated this object.
danielcdh added reviewers: dnovillo, davidxl.
danielcdh added a subscriber: llvm-commits.
dnovillo accepted this revision.Oct 7 2016, 7:56 AM
dnovillo edited edge metadata.

LGTM

This revision is now accepted and ready to land.Oct 7 2016, 7:56 AM
danielcdh closed this revision.Oct 7 2016, 8:30 AM
danielcdh added a comment.Oct 7 2016, 1:02 PM

Ping...

Renato, could you help take a look at this patch?

Thanks,
Dehao

Revision Contents

PathSize
test/
CodeGenCXX/
4 lines
CodeGenObjC/
5 lines

Diff 73149

test/CodeGenCXX/debug-info-line.cpp

// RUN: %clang_cc1 -w -debug-info-kind=line-tables-only -std=c++11 -fexceptions -fcxx-exceptions -S -emit-llvm %s -o - -triple %itanium_abi_triple | FileCheck %s // RUN: %clang_cc1 -w -debug-info-kind=line-tables-only -std=c++11 -fexceptions -fcxx-exceptions -S -mllvm -no-discriminators -emit-llvm %s -o - -triple %itanium_abi_triple | FileCheck %s
// RUN: %clang_cc1 -w -debug-info-kind=line-tables-only -std=c++11 -fexceptions -fcxx-exceptions -S -emit-llvm %s -o - -triple i686-linux-gnu | FileCheck %s // RUN: %clang_cc1 -w -debug-info-kind=line-tables-only -std=c++11 -fexceptions -fcxx-exceptions -S -mllvm -no-discriminators -emit-llvm %s -o - -triple i686-linux-gnu | FileCheck %s
int &src(); int &src();
int *sink(); int *sink();
extern "C" __complex float complex_src(); extern "C" __complex float complex_src();
extern "C" __complex float *complex_sink(); extern "C" __complex float *complex_sink();
// CHECK-LABEL: define // CHECK-LABEL: define
void f1() { void f1() {
▲ Show 20 Lines • Show All 312 Lines • Show Last 20 Lines

test/CodeGenObjC/arc-linetable-autorelease.m

Show All 24 Lines
- (NSBezierPath *)_createBezierPathWithWidth:(CGFloat)width height:(CGFloat)height radius:(CGFloat)radius lineWidth:(CGFloat)lineWidth - (NSBezierPath *)_createBezierPathWithWidth:(CGFloat)width height:(CGFloat)height radius:(CGFloat)radius lineWidth:(CGFloat)lineWidth
{ {
NSRect rect = NSMakeRect(0, 0, width, height); NSRect rect = NSMakeRect(0, 0, width, height);
NSBezierPath *path = [NSBezierPath bezierPathWithRoundedRect:rect xRadius:radius yRadius:radius]; NSBezierPath *path = [NSBezierPath bezierPathWithRoundedRect:rect xRadius:radius yRadius:radius];
CGFloat pattern[2]; CGFloat pattern[2];
// CHECK: define {{.*}}_createBezierPathWithWidth // CHECK: define {{.*}}_createBezierPathWithWidth
// CHECK: load {{.*}} %path, align {{.*}}, !dbg ![[RET:[0-9]+]] // CHECK: load {{.*}} %path, align {{.*}}, !dbg ![[RET:[0-9]+]]
// CHECK: call void @objc_storeStrong{{.*}} !dbg ![[ARC:[0-9]+]] // CHECK: call void @objc_storeStrong{{.*}} !dbg ![[ARC:[0-9]+]]
// CHECK: call {{.*}} @objc_autoreleaseReturnValue{{.*}} !dbg ![[ARC]] // CHECK: call {{.*}} @objc_autoreleaseReturnValue{{.*}} !dbg ![[ARC1:[0-9]+]]
// CHECK: ret {{.*}} !dbg ![[ARC]] // CHECK: ret {{.*}} !dbg ![[ARC]]
// CHECK: ![[RET]] = !DILocation(line: [[@LINE+1]], scope: !{{.*}}) // CHECK: ![[RET]] = !DILocation(line: [[@LINE+1]], scope: !{{.*}})
return path; return path;
// CHECK: ![[ARC]] = !DILocation(line: [[@LINE+1]], scope: !{{.*}}) // CHECK: ![[ARC]] = !DILocation(line: [[@LINE+2]], scope: !{{.*}})
// CHECK: ![[ARC1]] = !DILocation(line: [[@LINE+1]], scope: !{{.*}})
} }
@end @end