This is an archive of the discontinued LLVM Phabricator instance.

[libcxx] [cmake] Allow testing against installed LLVM with no sources
ClosedPublic

Authored by mgorny on Sep 30 2016, 7:25 AM.

Details

Summary

Adjust the stand-alone build files to accept either CMake files from LLVM_CMAKE_PATH or from LLVM_MAIN_SRC_DIR instead of requiring both. This makes it possible to run libcxx tests on top of installed LLVM and lit, without having to unpack a copy of LLVM sources. Furthermore, it avoids adding duplicate paths.

Diff Detail

Repository
rL LLVM

Event Timeline

mgorny updated this revision to Diff 73048.Sep 30 2016, 7:25 AM
mgorny retitled this revision from to [libcxx] [cmake] Allow testing against installed LLVM with no sources.
mgorny updated this object.
mgorny added reviewers: EricWF, beanz.
mgorny added a subscriber: cfe-commits.

Combined with D25076 (on llvm), this lets me run libcxx test suite on top of installed LLVM+lit, without LLVM sources.

Gentle ping.

beanz accepted this revision.Oct 18 2016, 2:49 PM
beanz edited edge metadata.

LGTM!

This revision is now accepted and ready to land.Oct 18 2016, 2:49 PM

Thanks for the review. Committed now.

This revision was automatically updated to reflect the committed changes.