This is an archive of the discontinued LLVM Phabricator instance.

Fix IntegerType::MAX_INT_BITS value
ClosedPublic

Authored by andreybokhanko on Sep 21 2016, 2:47 PM.

Details

Summary

IntegerType::MAX_INT_BITS is apparently not in sync with Type::SubclassData size. This patch fixes this.

Not sure it would be better to introduce a #define or something in Type.h with SubclassData's size and use it in both places. I haven't seen a precedent elsewhere in llvm, so simply added a comment.

Diff Detail

Event Timeline

andreybokhanko retitled this revision from to Fix IntegerType::MAX_INT_BITS value.
andreybokhanko updated this object.
andreybokhanko added reviewers: rnk, majnemer.
andreybokhanko added a subscriber: llvm-commits.
rnk accepted this revision.Oct 3 2016, 9:08 AM
rnk edited edge metadata.

lgtm

This revision is now accepted and ready to land.Oct 3 2016, 9:08 AM
This revision was automatically updated to reflect the committed changes.

Reid, thanks for looking at this!

Yours,
Andrey