This is an archive of the discontinued LLVM Phabricator instance.

[change-namespace] fix qualifier of function references.
ClosedPublic

Authored by ioeric on Sep 21 2016, 8:39 AM.

Diff Detail

Event Timeline

ioeric updated this revision to Diff 72054.Sep 21 2016, 8:39 AM
ioeric retitled this revision from to [change-namespace] fix qualifier of function references..
ioeric updated this object.
ioeric added a reviewer: hokein.
ioeric added a subscriber: cfe-commits.
hokein added inline comments.Sep 22 2016, 1:40 AM
change-namespace/ChangeNamespace.cpp
290

s/exlude/exclude.

unittests/change-namespace/ChangeNamespaceTests.cpp
317

Add a test for the case you mentioned in above?

// Ignore static methods since they will be handled by nested name specifiers.

ioeric updated this revision to Diff 72145.Sep 22 2016, 2:04 AM
ioeric marked 2 inline comments as done.
  • Addressing review comments: added a test case for out-of-line static method and fixed a bug.
hokein accepted this revision.Sep 22 2016, 4:50 AM
hokein edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Sep 22 2016, 4:50 AM
This revision was automatically updated to reflect the committed changes.