This is an archive of the discontinued LLVM Phabricator instance.

Fix unused result from sign extending an Offset.
ClosedPublic

Authored by srhines on Sep 15 2016, 11:43 PM.

Reviewers

echristo
cfe-commits

Commits

Summary

Offset was doubled in size, but the assignment was missing. We just need
to reassign to the original variable in this case to fix it.

srhines retitled this revision from to Fix unused result from sign extending an Offset..

srhines updated this object.

srhines added a reviewer: cfe-commits.

srhines added a subscriber: meikeb.

echristo added a reviewer: echristo.

This revision is now accepted and ready to land.Sep 16 2016, 12:25 AM

This revision was automatically updated to reflect the committed changes.

Path

Size

cfe/

trunk/

lib/

Sema/

2 lines

Show First 20 Lines • Show All 3,876 Lines • ▼ Show 20 Lines	assert(AddendIsRight && BinOpKind == BO_Sub &&
"operator must be add or sub with addend on the right");		"operator must be add or sub with addend on the right");
ResOffset = Offset.ssub_ov(Addend, Ov);		ResOffset = Offset.ssub_ov(Addend, Ov);
}		}

// We add an offset to a pointer here so we should support an offset as big as		// We add an offset to a pointer here so we should support an offset as big as
// possible.		// possible.
if (Ov) {		if (Ov) {
assert(BitWidth <= UINT_MAX / 2 && "index (intermediate) result too big");		assert(BitWidth <= UINT_MAX / 2 && "index (intermediate) result too big");
Offset.sext(2 * BitWidth);		Offset = Offset.sext(2 * BitWidth);
sumOffsets(Offset, Addend, BinOpKind, AddendIsRight);		sumOffsets(Offset, Addend, BinOpKind, AddendIsRight);
return;		return;
}		}

Offset = ResOffset;		Offset = ResOffset;
}		}

namespace {		namespace {
▲ Show 20 Lines • Show All 7,333 Lines • Show Last 20 Lines