This is an archive of the discontinued LLVM Phabricator instance.

Fix unlucky tests
ClosedPublic

Authored by kubamracek on Sep 15 2016, 4:43 AM.

Details

Summary

These tests have been failing on my machine:
Failing Tests (3):

SanitizerCommon-asan-i386-Linux :: Posix/dedup_token_length_test.cc
SanitizerCommon-asan-i686-Linux :: Posix/dedup_token_length_test.cc
SanitizerCommon-asan-x86_64-Linux :: Posix/dedup_token_length_test.cc

with

/home/csabaraduly/workspace/LLVM/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Posix/dedup_token_length_test.cc:37:16: note: CHECK1-NOT: pattern specified here
// CHECK1-NOT: bar

because my username (csabaraduly) causes a false positive.

Diff Detail

Event Timeline

Bulletmagnet retitled this revision from to Fix unlucky tests.
Bulletmagnet updated this object.
Bulletmagnet added reviewers: mehdi_amini, kcc.
Bulletmagnet set the repository for this revision to rL LLVM.
Bulletmagnet changed the visibility from "Public (No Login Required)" to "All Users".
kubamracek accepted this revision.Sep 15 2016, 4:48 AM
kubamracek added a reviewer: kubamracek.

LOL. LGTM.

This revision is now accepted and ready to land.Sep 15 2016, 4:48 AM
mehdi_amini edited edge metadata.Sep 15 2016, 8:24 AM

A better (more principled) way of fixing this is to make sure the environment does not leak in the test output.

Please commit; I only have read-only access.

kubamracek commandeered this revision.Sep 19 2016, 2:56 AM
kubamracek edited reviewers, added: Bulletmagnet; removed: kubamracek.
This revision now requires review to proceed.Sep 19 2016, 2:56 AM
kubamracek updated this revision to Diff 71788.Sep 19 2016, 2:57 AM
kubamracek edited edge metadata.
kubamracek removed rL LLVM as the repository for this revision.
kubamracek changed the visibility from "All Users" to "Public (No Login Required)".

Updating the patch to use “--match-full-lines” instead of CHECK-NOT.

A better (more principled) way of fixing this is to make sure the environment does not leak in the test output.

Right. I think changing the behavior of the symbolizer not to print out full file paths is too invasive. How about just checking full line outputs instead of the CHECK-NOT’s? I already updated this revision with a new patch.

I didn't know this option. Sweet!

This revision was automatically updated to reflect the committed changes.