Fix unlucky tests

[kubamracek]

Summary

These tests have been failing on my machine:
Failing Tests (3):

SanitizerCommon-asan-i386-Linux :: Posix/dedup_token_length_test.cc
SanitizerCommon-asan-i686-Linux :: Posix/dedup_token_length_test.cc
SanitizerCommon-asan-x86_64-Linux :: Posix/dedup_token_length_test.cc

with

/home/csabaraduly/workspace/LLVM/llvm/projects/compiler-rt/test/sanitizer_common/TestCases/Posix/dedup_token_length_test.cc:37:16: note: CHECK1-NOT: pattern specified here
// CHECK1-NOT: bar

because my username (csabaraduly) causes a false positive.

[kubamracek]

LOL. LGTM.

[mehdi_amini]

A better (more principled) way of fixing this is to make sure the environment does not leak in the test output.

[Bulletmagnet]

Please commit; I only have read-only access.

[kubamracek]

Updating the patch to use “--match-full-lines” instead of CHECK-NOT.

[kubamracek]

A better (more principled) way of fixing this is to make sure the environment does not leak in the test output.

Right. I think changing the behavior of the symbolizer not to print out full file paths is too invasive. How about just checking full line outputs instead of the CHECK-NOT’s? I already updated this revision with a new patch.

[mehdi_amini]

I didn't know this option. Sweet!

test/sanitizer_common/TestCases/Posix/dedup_token_length_test.cc

 // Test dedup_token_length
 // RUN: %clangxx -O0 %s -o %t
-// RUN: env %tool_options='abort_on_error=0'                    not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK0
-// RUN: env %tool_options='abort_on_error=0, dedup_token_length=0' not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK0
-// RUN: env %tool_options='abort_on_error=0, dedup_token_length=1' not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK1
-// RUN: env %tool_options='abort_on_error=0, dedup_token_length=2' not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK2
-// RUN: env %tool_options='abort_on_error=0, dedup_token_length=3' not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK3
+// RUN: env %tool_options='abort_on_error=0'                       not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK0 --match-full-lines
+// RUN: env %tool_options='abort_on_error=0, dedup_token_length=0' not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK0 --match-full-lines
+// RUN: env %tool_options='abort_on_error=0, dedup_token_length=1' not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK1 --match-full-lines
+// RUN: env %tool_options='abort_on_error=0, dedup_token_length=2' not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK2 --match-full-lines
+// RUN: env %tool_options='abort_on_error=0, dedup_token_length=3' not %run %t 2>&1   | FileCheck %s --check-prefix=CHECK3 --match-full-lines
 
 // REQUIRES: stable-runtime
 // FIXME: implement SEGV handler in other sanitizers, not just asan.
 // XFAIL: msan
 // XFAIL: lsan
 // XFAIL: tsan
 
 volatile int *null = 0;

 }
 
 int main(int argc, char **argv) {
   FOO();
 }
 
 // CHECK0-NOT: DEDUP_TOKEN:
 // CHECK1: DEDUP_TOKEN: void Xyz::Abc<int, int>()
-// CHECK1-NOT: bar
 // CHECK2: DEDUP_TOKEN: void Xyz::Abc<int, int>()--bar
-// CHECK2-NOT: FOO
 // CHECK3: DEDUP_TOKEN: void Xyz::Abc<int, int>()--bar--FOO()