This is an archive of the discontinued LLVM Phabricator instance.

Add support for DW_AT_ranges_base attribute
ClosedPublic

Authored by tberghammer on Sep 13 2016, 10:04 AM.

Details

Summary

Add support for DW_AT_ranges_base attribute

It is a new attribute emitted by clang as a GNU extension and will
be part of Dwarf5. The purpose of the attribute is to specify a compile
unit level base value for all DW_AT_ranges to reduce the number of
relocation have to be done by the linker.

Fixes (at least partially): https://llvm.org/pr28826

Diff Detail

Event Timeline

tberghammer retitled this revision from to Add support for DW_AT_ranges_base attribute.
tberghammer updated this object.
tberghammer added reviewers: labath, clayborg.
tberghammer added a subscriber: lldb-commits.
labath edited edge metadata.Sep 14 2016, 2:07 AM

Looks straight-forward enough. However, it could use a test-case.

tberghammer edited edge metadata.

Adding a new test case

Thanks for adding the test case. LGTM from my side.

clayborg accepted this revision.Sep 14 2016, 8:49 AM
clayborg edited edge metadata.

Looks good.

This revision is now accepted and ready to land.Sep 14 2016, 8:49 AM
This revision was automatically updated to reflect the committed changes.