This is an archive of the discontinued LLVM Phabricator instance.

clang-format: [JS] Do not wrap taze: IWYU comments
ClosedPublic

Authored by mprobst on Sep 12 2016, 3:31 PM.

Details

Summary

See (sorry, internal link): go/taze#global-symbols-dts-externs.

Before:

// taze: many, different, symbols from
// //some/long/iwyu/style/target

After:

// taze: many, different, symbols from //some/long/iwyu/style/target

Diff Detail

Repository
rL LLVM

Event Timeline

mprobst updated this revision to Diff 71062.Sep 12 2016, 3:31 PM
mprobst retitled this revision from to clang-format: [JS] Do not wrap taze: IWYU comments.
mprobst updated this object.
mprobst added a reviewer: djasper.
mprobst added a subscriber: cfe-commits.
mprobst updated this revision to Diff 71189.Sep 13 2016, 9:45 AM
  • update commit msg
  • make test case a bit more generic
djasper accepted this revision.Sep 13 2016, 9:46 AM
djasper edited edge metadata.

Generally looks good.

unittests/Format/FormatTestJS.cpp
1433 ↗(On Diff #71189)

Maybe here, too? I don't think many people are familiar with bazel target syntax ;).

This revision is now accepted and ready to land.Sep 13 2016, 9:46 AM
mprobst marked an inline comment as done.Sep 13 2016, 9:54 AM
This revision was automatically updated to reflect the committed changes.