This is an archive of the discontinued LLVM Phabricator instance.

IfConversion: Add assertions that both sides of a diamond don't pred-clobber.
ClosedPublic

Authored by iteratee on Sep 1 2016, 6:38 PM.

Details

Reviewers
davidxl
Summary

One side of a diamond may end with a predicate clobbering instruction.
That side of the diamond has to be if-converted second. Both sides can't
clobber the predicate or the ifconversion is invalid. This is checked
elsewhere, but add an assert as a safety check. NFC

Diff Detail

Event Timeline

iteratee updated this revision to Diff 70126.Sep 1 2016, 6:38 PM
iteratee updated this revision to Diff 70127.
iteratee retitled this revision from to IfConversion: Add assertions that both sides of a diamond don't pred-clobber..
iteratee updated this object.
iteratee added a reviewer: davidxl.
iteratee set the repository for this revision to rL LLVM.
iteratee removed rL LLVM as the repository for this revision.
iteratee added a subscriber: llvm-commits.

Assertion split into separate revision.

davidxl accepted this revision.Sep 1 2016, 7:15 PM
davidxl edited edge metadata.

lgtm

This revision is now accepted and ready to land.Sep 1 2016, 7:15 PM
Eugene.Zelenko closed this revision.Oct 4 2016, 2:17 PM
Eugene.Zelenko added a subscriber: Eugene.Zelenko.

Committed in rL280517. Please specify "Differential revision: <URL>" in commit message.

Committed in rL280517. Please specify "Differential revision: <URL>" in commit message.

Actually this was committed in RL280518. Sorry about the URL missing.