This is an archive of the discontinued LLVM Phabricator instance.

Document option '-rtlib' in clang's man page and help info
ClosedPublic

Authored by zlei on Aug 31 2016, 12:56 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

zlei updated this revision to Diff 69804.Aug 31 2016, 12:56 AM
zlei retitled this revision from to Document option '-rtlib' in clang's man page and help info.
zlei updated this object.
zlei added reviewers: cfe-commits, Hahnfeld.
bruno added a subscriber: bruno.Aug 31 2016, 11:11 AM

Hi Lei,

Thanks for the doc improvement!

docs/CommandGuide/clang.rst
114 ↗(On Diff #69804)

It might be worth mentioning what's the default behaviour in case the flag isn't specified?

zlei added inline comments.Aug 31 2016, 5:30 PM
docs/CommandGuide/clang.rst
114 ↗(On Diff #69804)

This option behaves a lot like -stdlib, so I want their doc entries to look alike too. Perhaps I should update them both to state the default behavior?

bruno added inline comments.Aug 31 2016, 5:42 PM
docs/CommandGuide/clang.rst
114 ↗(On Diff #69804)

That would be great, but feel free to do this update in follow up patches/commits if you want to.

zlei updated this revision to Diff 69947.Aug 31 2016, 11:16 PM
zlei edited reviewers, added: bruno; removed: cfe-commits.
zlei edited subscribers, added: cfe-commits; removed: bruno.

Update the man page entry to state default behavior of this option.

Hahnfeld accepted this revision.Sep 12 2016, 12:56 AM
Hahnfeld edited edge metadata.

LGTM, thanks for the improvement!

This revision is now accepted and ready to land.Sep 12 2016, 12:56 AM

@zlei will you commit the patch or do you want me to do that on your behalf?

zlei added a comment.Sep 13 2016, 5:43 PM

@zlei will you commit the patch or do you want me to do that on your behalf?

I don't have commit access, so please do me a favor :)

This revision was automatically updated to reflect the committed changes.