Page MenuHomePhabricator

AMDGPU/SI: Make sure llvm.amdgcn.implicitarg.ptr() is at least 4-byte aligned
ClosedPublic

Authored by tstellarAMD on Aug 30 2016, 12:30 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

tstellarAMD retitled this revision from to AMDGPU/SI: Make sure llvm.amdgcn.implicitarg.ptr() is at least 4-byte aligned.
tstellarAMD updated this object.
tstellarAMD added reviewers: arsenm, jvesely.
tstellarAMD added a subscriber: llvm-commits.
arsenm accepted this revision.Aug 30 2016, 2:32 PM
arsenm edited edge metadata.

LGTM. I still think we should fix this to be the offset from the base pointer though

This revision is now accepted and ready to land.Aug 30 2016, 2:32 PM
jvesely accepted this revision.Aug 30 2016, 7:22 PM
jvesely edited edge metadata.

lgtm. sorry about the breakage.

matt, I don't see how offset would fix this. pointer is more generic. If you know it's the same AS you can get the offset by subtracting, and it leaves open the option of being in different AS.

This revision was automatically updated to reflect the committed changes.