Page MenuHomePhabricator

Use 'critical' reduction method when 'atomic' is not available but requested.
ClosedPublic

Authored by omalyshe on Aug 29 2016, 6:05 AM.

Details

Summary

In case atomic reduction method is not available (the compiler can't generate it) the assertion failure occurred if KMP_FORCE_REDUCTION=atomic was specified.
This change replaces the assertion with a warning and sets the reduction method to the default one - 'critical'.

Diff Detail

Repository
rL LLVM

Event Timeline

omalyshe updated this revision to Diff 69562.Aug 29 2016, 6:05 AM
omalyshe retitled this revision from to Use 'critical' reduction method when 'atomic' is not available but requested..
omalyshe updated this object.
omalyshe set the repository for this revision to rL LLVM.
omalyshe added a subscriber: openmp-commits.
jlpeyton accepted this revision.Aug 29 2016, 10:38 AM
jlpeyton edited edge metadata.

LGTM.

This revision is now accepted and ready to land.Aug 29 2016, 10:38 AM
This revision was automatically updated to reflect the committed changes.