Page MenuHomePhabricator

Delete dead code
AbandonedPublic

Authored by espindola on Aug 26 2016, 12:35 PM.

Details

Summary

While support for explicit preemption in the llvm IR would use something like this, it can be a long time before such support is added. Before that happens this is dead code and should probably be deleted.

Diff Detail

Event Timeline

rafael retitled this revision from to Delete dead code.
rafael updated this object.
rafael added reviewers: tejohnson, pcc.
rafael added a subscriber: llvm-commits.
rafael updated this object.Aug 26 2016, 12:37 PM

We should be able to skip the GOT/PLT for such symbols in the codegen right now, wouldn't we?

tejohnson edited edge metadata.Aug 26 2016, 1:04 PM

I tend to agree to remove it, since it isn't being used at all yet. But I think some llvm-lto2 tests need to be updated (that's the only way this could get set now). E.g. test/ThinLTO/X86/internalize.ll

rafael updated this revision to Diff 69564.Aug 29 2016, 6:24 AM
rafael edited edge metadata.

Exit with error on unknown character.

espindola commandeered this revision.Mar 6 2018, 5:32 PM
espindola added a reviewer: rafael.
pcc added a comment.Mar 6 2018, 5:36 PM

I guess this can be abandoned now, right?

espindola abandoned this revision.Mar 6 2018, 5:39 PM

Yes, dso_local exists and is getting more common.