This is an archive of the discontinued LLVM Phabricator instance.

[Modules] Add 'freestanding' to the 'requires-declaration' feature-list.
ClosedPublic

Authored by eladcohen on Aug 25 2016, 7:14 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

eladcohen updated this revision to Diff 69239.Aug 25 2016, 7:14 AM
eladcohen retitled this revision from to [Modules] Add 'freestanding' to the 'requires-declaration' feature-list..
eladcohen updated this object.
eladcohen added reviewers: rsmith, andreybokhanko.
eladcohen added a subscriber: cfe-commits.
rsmith accepted this revision.Aug 25 2016, 2:49 PM
rsmith edited edge metadata.

Makes sense to me. I imagine this would also be useful for libc++.

lib/Headers/module.modulemap
66 ↗(On Diff #69239)

Are there more parts of the intrinsics modules to which this should be applied?

This revision is now accepted and ready to land.Aug 25 2016, 2:49 PM
eladcohen added inline comments.Aug 27 2016, 12:22 PM
lib/Headers/module.modulemap
66 ↗(On Diff #69239)

Not that I'm aware of. A "STDC_HOSTED" grep on the intrinsics modules header files didn't find anything other than mm_malloc.h.

This revision was automatically updated to reflect the committed changes.

Thanks Richard, committed r280613.