This is an archive of the discontinued LLVM Phabricator instance.

[ELF] - Introduce StripPolicy instead of Config->StripAll/StripDebug flags.
ClosedPublic

Authored by grimar on Aug 25 2016, 6:25 AM.

Details

Diff Detail

Event Timeline

grimar updated this revision to Diff 69231.Aug 25 2016, 6:25 AM
grimar retitled this revision from to [ELF] - Introduce StripPolicy instead of Config->StripAll/StripDebug flags..
grimar updated this object.
grimar added reviewers: ruiu, rafael.
grimar added subscribers: llvm-commits, grimar.
ruiu added inline comments.Aug 29 2016, 3:38 PM
ELF/Config.h
35

Needs a comment.

ELF/Driver.cpp
351

Add {}.

398

I'd make it explicit that the function depends on Config->Relocatable and move it where the previous assignment to Strip{All,Debug} was.

if (!Config->Relocatable)
  Config->Strip = getStripOption(Args);

Otherwise, it seems to happened to be here because of the alphabetical order.

grimar updated this revision to Diff 69687.Aug 30 2016, 8:14 AM
  • Addressed review comments.
ELF/Config.h
35

Done.

ELF/Driver.cpp
351

Done.

398

Done.

ruiu accepted this revision.Aug 30 2016, 12:17 PM
ruiu edited edge metadata.

LGTM

This revision is now accepted and ready to land.Aug 30 2016, 12:17 PM
This revision was automatically updated to reflect the committed changes.