[analyzer] Fixed crash in StmtDataCollector when analyzing methods of template classes.

[teemperor]

Summary

The current check with isTemplateInstantiation() is also returning true when calling a member method of a template class. In this case getTemplateSpecializationArgs() returns a null pointer and we crash. It seems the intended way to check for template specialization args is to make a nullptr check on getTemplateSpecializationArgs() which we start doing with this patch. We don't need to add any code for the member methods of template classes as the qualified type of the calling object already contains the template arguments of the class.

[NoQ]

Yeah, it seems that these need to be checked.

cfe/trunk/lib/Analysis/CloneDetection.cpp

DEF_ADD_DATA(TypeTraitExpr, {
     for (unsigned i = 0; i < S->getNumArgs(); ++i)
       addData(S->getArg(i)->getType());
   })
 
   //--- Calls --------------------------------------------------------------//
   DEF_ADD_DATA(CallExpr, {
     // Function pointers don't have a callee and we just skip hashing it.
     if (const FunctionDecl *D = S->getDirectCallee()) {
-      // If the function is a template instantiation, we also need to handle
-      // the template arguments as they are no included in the qualified name.
-      if (D->isTemplateInstantiation()) {
-        auto Args = D->getTemplateSpecializationArgs();
+      // If the function is a template specialization, we also need to handle
+      // the template arguments as they are not included in the qualified name.
+      if (auto Args = D->getTemplateSpecializationArgs()) {
         std::string ArgString;
 
         // Print all template arguments into ArgString
         llvm::raw_string_ostream OS(ArgString);
         for (unsigned i = 0; i < Args->size(); ++i) {
           Args->get(i).print(Context.getLangOpts(), OS);
           // Add a padding character so that 'foo<X, XX>()' != 'foo<XX, X>()'.
           OS << '\n';

cfe/trunk/test/Analysis/copypaste/call.cpp

 
 bool fooTemplatePadding2(int x) {
   if (x > 0)
     return false;
   else if (x < 0)
     return templatePaddingFunc<XX, X>();
   return true;
 }
+
+// Test that we don't crash on member functions of template instantiations.
+
+template<typename T>
+struct A {
+  void foo(T t) {}
+};
+
+void fooTestInstantiation() {
+  A<int> a;
+  a.foo(1);
+}