This is an archive of the discontinued LLVM Phabricator instance.

[asan] Use 1 byte aligned stores to poison shadow memory
ClosedPublic

Authored by vitalybuka on Aug 21 2016, 8:47 PM.

Reviewers

Commits

Summary

r279379 introduced crash on arm 32bit bot. I suspect this is alignment issue.

vitalybuka retitled this revision from to [asan] Use 1 byte aligned stores to poison shadow memory.

vitalybuka updated this object.

vitalybuka added a reviewer: eugenis.

This revision was automatically updated to reflect the committed changes.

Path

Size

llvm/

trunk/

lib/

Transforms/

Instrumentation/

4 lines

Show First 20 Lines • Show All 2,005 Lines • ▼ Show 20 Lines	if (DoPoison) {
}		}
assert(Val); // Impossible because ShadowBytes[i] != 0		assert(Val); // Impossible because ShadowBytes[i] != 0
} else {		} else {
Val = 0;		Val = 0;
}		}

Value *Ptr = IRB.CreateAdd(ShadowBase, ConstantInt::get(IntptrTy, i));		Value *Ptr = IRB.CreateAdd(ShadowBase, ConstantInt::get(IntptrTy, i));
Value Poison = IRB.getIntN(StoreSizeInBytes 8, Val);		Value Poison = IRB.getIntN(StoreSizeInBytes 8, Val);
IRB.CreateStore(Poison,		IRB.CreateAlignedStore(
IRB.CreateIntToPtr(Ptr, Poison->getType()->getPointerTo()));		Poison, IRB.CreateIntToPtr(Ptr, Poison->getType()->getPointerTo()), 1);

i += StoreSizeInBytes;		i += StoreSizeInBytes;
}		}
}		}

void FunctionStackPoisoner::poisonStackFrame(ArrayRef<uint8_t> ShadowBytes,		void FunctionStackPoisoner::poisonStackFrame(ArrayRef<uint8_t> ShadowBytes,
IRBuilder<> &IRB,		IRBuilder<> &IRB,
Value *ShadowBase, bool DoPoison) {		Value *ShadowBase, bool DoPoison) {
▲ Show 20 Lines • Show All 457 Lines • Show Last 20 Lines