Page MenuHomePhabricator

clang-format: [JS] supports casts to types starting with punctuation ("{[(").
ClosedPublic

Authored by mprobst on Aug 21 2016, 11:21 AM.

Diff Detail

Repository
rL LLVM

Event Timeline

mprobst updated this revision to Diff 68817.Aug 21 2016, 11:21 AM
mprobst retitled this revision from to clang-format: [JS] supports casts to types starting with punctuation ("{[(")..
mprobst updated this object.
mprobst added a reviewer: djasper.
mprobst added subscribers: cfe-commits, klimek.
ygao added a subscriber: ygao.Aug 21 2016, 4:11 PM
ygao added inline comments.
lib/Format/FormatTokenLexer.cpp
245 ↗(On Diff #68817)

What happens if the '${' is immediately after a backslash (the if statement above), should the '${' get escaped?

mprobst updated this revision to Diff 68844.Aug 22 2016, 4:23 AM
  • drop accidentally included template string patch from this diff.
mprobst marked an inline comment as done.Aug 22 2016, 4:23 AM
mprobst added inline comments.
lib/Format/FormatTokenLexer.cpp
245 ↗(On Diff #68817)

Sorry, I accidentally included this in the wrong diff – the template string thing is in D22431. I'll answer there.

djasper accepted this revision.Aug 22 2016, 7:21 AM
djasper edited edge metadata.

Please add a "before" and "after" to the patch description before submitting. Otherwise looks good.

This revision is now accepted and ready to land.Aug 22 2016, 7:21 AM
mprobst updated this object.Aug 22 2016, 7:30 AM
mprobst edited edge metadata.
This revision was automatically updated to reflect the committed changes.
mprobst marked an inline comment as done.