This is an archive of the discontinued LLVM Phabricator instance.

lit/setup.py: Install as llvm-lit (as cmake expects it)
AbandonedPublic

Authored by mgorny on Aug 20 2016, 4:52 AM.

Details

Summary

Modify the setup.py for lit to install the entry point as llvm-lit (instead of lit) since this is the name expected by functions in AddLLVM.cmake.

Diff Detail

Event Timeline

mgorny updated this revision to Diff 68774.Aug 20 2016, 4:52 AM
mgorny retitled this revision from to lit/setup.py: Install as llvm-lit (as cmake expects it).
mgorny updated this object.
mgorny added reviewers: garious, ddunbar.
mgorny added a subscriber: llvm-commits.
ddunbar requested changes to this revision.Sep 1 2016, 8:26 PM
ddunbar edited edge metadata.

This isn't correct, llvm-lit is something else (an llvm specific entry point to lit that knows the object directory). That doesn't belong in the base lit project.

This revision now requires changes to proceed.Sep 1 2016, 8:26 PM
mgorny added a comment.Sep 1 2016, 9:53 PM

So what should be done? Should the cmake functions be modified to look for both llvm-lit and lit?

I'm talking of add_lit_target() that is using:

find_program(LIT_COMMAND llvm-lit)

when LLVM_MAIN_SRC_DIR is unset.

mgorny abandoned this revision.Sep 20 2016, 10:22 AM