This is an archive of the discontinued LLVM Phabricator instance.

Differential D23650

Use target name instead of namespace as prefix for MCRegisterClasses array
ClosedPublic

Authored by dcederman on Aug 18 2016, 2:22 AM.

Details

Reviewers
jyknight
Commits
rG3bc6fe78f62f: [Sparc] Use target name instead of namespace as prefix for MCRegisterClasses…
rL287528: [Sparc] Use target name instead of namespace as prefix for MCRegisterClasses…
Summary

For Sparc the namespace (SP) is different from the target name (Sparc),
which causes the name of the array in this declaration to differ from
the name used in the definition.

Diff Detail

Repository
rL LLVM

Event Timeline

dcederman updated this revision to Diff 68498.Aug 18 2016, 2:22 AM
dcederman retitled this revision from to Use target name instead of namespace as prefix for MCRegisterClasses array.
dcederman updated this object.
dcederman added a subscriber: llvm-commits.
Herald added a subscriber: jyknight. · View Herald TranscriptAug 18 2016, 2:22 AM
dcederman added a reviewer: jyknight.Sep 6 2016, 4:35 AM
dcederman added a child revision: D24247: [SPARC] Add assembler for the REX instruction set extension.Sep 6 2016, 9:21 AM
jyknight accepted this revision.Oct 18 2016, 1:51 PM
jyknight edited edge metadata.
This revision is now accepted and ready to land.Oct 18 2016, 1:51 PM
Closed by commit rL287528: [Sparc] Use target name instead of namespace as prefix for MCRegisterClasses… (authored by jacob_hansen). · Explain WhyNov 21 2016, 1:42 AM
This revision was automatically updated to reflect the committed changes.

Revision Contents

PathSize
llvm/
trunk/
utils/
TableGen/
2 lines

Diff 78695

llvm/trunk/utils/TableGen/RegisterInfoEmitter.cpp

Show First 20 Lines • Show All 98 Lines • ▼ Show 20 Linesvoid RegisterInfoEmitter::runEnums(raw_ostream &OS,
emitSourceFileHeader("Target Register Enum Values", OS); emitSourceFileHeader("Target Register Enum Values", OS);
OS << "\n#ifdef GET_REGINFO_ENUM\n"; OS << "\n#ifdef GET_REGINFO_ENUM\n";
OS << "#undef GET_REGINFO_ENUM\n\n"; OS << "#undef GET_REGINFO_ENUM\n\n";
OS << "namespace llvm {\n\n"; OS << "namespace llvm {\n\n";
OS << "class MCRegisterClass;\n" OS << "class MCRegisterClass;\n"
<< "extern const MCRegisterClass " << Namespace << "extern const MCRegisterClass " << Target.getName()
<< "MCRegisterClasses[];\n\n"; << "MCRegisterClasses[];\n\n";
if (!Namespace.empty()) if (!Namespace.empty())
OS << "namespace " << Namespace << " {\n"; OS << "namespace " << Namespace << " {\n";
OS << "enum {\n NoRegister,\n"; OS << "enum {\n NoRegister,\n";
for (const auto &Reg : Registers) for (const auto &Reg : Registers)
OS << " " << Reg.getName() << " = " << Reg.EnumValue << ",\n"; OS << " " << Reg.getName() << " = " << Reg.EnumValue << ",\n";
▲ Show 20 Lines • Show All 1,420 Lines • Show Last 20 Lines