Page MenuHomePhabricator

jacob_hansen (Jacob Baungård Hansen)
User

Projects

User does not belong to any projects.

User Details

User Since
Nov 30 2015, 2:15 AM (203 w, 2 h)

Recent Activity

Dec 12 2017

jacob_hansen added a comment to D39425: [Sparc] Account for bias in stack readjustment.

Can you please add a test for this? There is already a test in stack-align.ll that covers 32bit stack realignment, you can probably modify that testcase to cover 64bit also.

Dec 12 2017, 7:29 AM

Jul 19 2017

jacob_hansen accepted D35576: [SPARC] Clean up the support for disabling fsmuld and fmuls instructions..

Thanks for cleaning this up. LGTM.

Jul 19 2017, 2:49 AM

Jul 18 2017

jacob_hansen added a comment to D35500: [Sparc] Added software multiplication/division feature.

I assume the .mul/.sdiv/.udiv routines must be provided by linking to libgcc or glibc?

Jul 18 2017, 6:22 AM

Nov 24 2016

jacob_hansen committed rL287856: TableGen: Allow signed immediates for instruction aliases.
TableGen: Allow signed immediates for instruction aliases
Nov 24 2016, 1:03 AM
jacob_hansen closed D27046: TableGen: Allow signed immediates for instruction aliases by committing rL287856: TableGen: Allow signed immediates for instruction aliases.
Nov 24 2016, 1:03 AM

Nov 21 2016

jacob_hansen committed rL287528: [Sparc] Use target name instead of namespace as prefix for MCRegisterClasses….
[Sparc] Use target name instead of namespace as prefix for MCRegisterClasses…
Nov 21 2016, 1:43 AM
jacob_hansen closed D23650: Use target name instead of namespace as prefix for MCRegisterClasses array by committing rL287528: [Sparc] Use target name instead of namespace as prefix for MCRegisterClasses….
Nov 21 2016, 1:43 AM

Jul 13 2016

jacob_hansen updated subscribers of rL273108: [SPARC] Fixes for hardware errata on LEON processor..
Jul 13 2016, 7:00 AM

Jul 4 2016

jacob_hansen added a comment to D21960: [Sparc] Leon errata fixes passes..

Can't seem to find tests for the following passes:

Jul 4 2016, 7:50 AM
jacob_hansen committed rL274487: [Sparc] Allow LEON cpu models to be selected with -mcpu.
[Sparc] Allow LEON cpu models to be selected with -mcpu
Jul 4 2016, 2:03 AM
jacob_hansen closed D21683: [Sparc] Allow LEON cpu models to be selected with -mcpu by committing rL274487: [Sparc] Allow LEON cpu models to be selected with -mcpu.
Jul 4 2016, 2:03 AM

Jun 24 2016

jacob_hansen retitled D21683: [Sparc] Allow LEON cpu models to be selected with -mcpu from to [Sparc] Allow LEON cpu models to be selected with -mcpu.
Jun 24 2016, 7:20 AM

Jun 22 2016

jacob_hansen updated subscribers of rL273108: [SPARC] Fixes for hardware errata on LEON processor..

Can you run the code through clang-format please? There's a few columns that are too long etc.

Jun 22 2016, 5:17 AM
jacob_hansen updated subscribers of rL273108: [SPARC] Fixes for hardware errata on LEON processor..
Jun 22 2016, 5:16 AM

May 24 2016

jacob_hansen committed rL270538: [Sparc] Add software float option -msoft-float.
[Sparc] Add software float option -msoft-float
May 24 2016, 1:36 AM
jacob_hansen closed D20419: [Sparc] Add software float option -msoft-float by committing rL270538: [Sparc] Add software float option -msoft-float.
May 24 2016, 1:36 AM
jacob_hansen updated the diff for D20419: [Sparc] Add software float option -msoft-float.

Corrected formatting of a line that exceeded 80 columns.

May 24 2016, 1:30 AM
jacob_hansen updated the diff for D20419: [Sparc] Add software float option -msoft-float.

Updated against latest master in preparation for commit.

May 24 2016, 1:15 AM

May 23 2016

jacob_hansen committed rL270435: Test commit.
Test commit
May 23 2016, 6:19 AM
jacob_hansen committed rL270414: Test commit.
Test commit
May 23 2016, 2:48 AM

May 19 2016

jacob_hansen added inline comments to D20353: [Sparc][LEON] Erratum fix. Insert NOP after LD or LDF instruction.
May 19 2016, 8:52 AM
jacob_hansen updated the diff for D20419: [Sparc] Add software float option -msoft-float.
  • Corrected an error causing the "target-features"="+soft-float" attribute to not be correctly set
  • Improved the function-target-features test
May 19 2016, 2:53 AM
jacob_hansen retitled D20419: [Sparc] Add software float option -msoft-float from to [Sparc] Add software float option -msoft-float.
May 19 2016, 2:25 AM

May 11 2016

jacob_hansen updated the diff for D19265: [Sparc] Add Soft Float support.

Accidentally removed two tests from 32abi.ll in the previous revision, this revision reintroduces them.

May 11 2016, 4:28 AM

May 10 2016

jacob_hansen updated the diff for D19265: [Sparc] Add Soft Float support.

The following have been updated in this patch:

May 10 2016, 8:20 AM

May 2 2016

jacob_hansen added a comment to D19797: [Sparc] Constification of TargetMachine arguments.

Do you not have commit access yet?

May 2 2016, 7:49 AM
jacob_hansen added a child revision for D19797: [Sparc] Constification of TargetMachine arguments: D19265: [Sparc] Add Soft Float support.
May 2 2016, 2:48 AM
jacob_hansen added a parent revision for D19265: [Sparc] Add Soft Float support: D19797: [Sparc] Constification of TargetMachine arguments.
May 2 2016, 2:48 AM
jacob_hansen updated the diff for D19265: [Sparc] Add Soft Float support.

Removed the subtarget object from the TargetMachine and changed the way 32/64 bit ness is determined as requested.

May 2 2016, 2:48 AM
jacob_hansen added inline comments to D19265: [Sparc] Add Soft Float support.
May 2 2016, 2:24 AM
jacob_hansen retitled D19797: [Sparc] Constification of TargetMachine arguments from to [Sparc] Constification of TargetMachine arguments.
May 2 2016, 2:23 AM

Apr 27 2016

jacob_hansen added a comment to D19265: [Sparc] Add Soft Float support.

The change should use the same calling convention as GCC does, yes. I tested the change by linking with libgcc (from http://www.gaisler.com/index.php/products/operating-systems/bcc) which contains implementation of all the floating point procedures, that seemed to work perfectly. I also tested it by manually compiling a library of the builtins from the Compiler-RT project (Compiler-RT builtins are compatible with libgcc as noted on http://compiler-rt.llvm.org/), and that worked as well.

Apr 27 2016, 10:00 AM

Apr 22 2016

jacob_hansen accepted D19368: Allow Sparc back-end to take the address of a function (or other global object).

This looks good for me (not sure I can formally accept it as I do not yet have SVN write access though).

Apr 22 2016, 1:01 AM
jacob_hansen updated D19265: [Sparc] Add Soft Float support.
Apr 22 2016, 12:52 AM

Apr 21 2016

jacob_hansen updated subscribers of D19359: Sparc itineraries support, with LEON3 and LEON4 itineraries added.
Apr 21 2016, 7:36 AM

Apr 20 2016

jacob_hansen updated the diff for D19265: [Sparc] Add Soft Float support.

I had initially planned to do this over two patches but changed my mind a decided it was better to do it in one. This updated patch ensures that the soft-float attribute is retained when the target options are being reset (this change is identical to how other targets handles this situation).

Apr 20 2016, 7:31 AM

Apr 19 2016

jacob_hansen updated the diff for D19265: [Sparc] Add Soft Float support.

Reintroduced the header on line 1 of SparcISelLowering.h which was accidentally removed.

Apr 19 2016, 8:38 AM
jacob_hansen retitled D19265: [Sparc] Add Soft Float support from to [Sparc] Add Soft Float support.
Apr 19 2016, 8:33 AM

Feb 8 2016

jacob_hansen added a comment to rL254199: Revert Sparc and SparcV9 to external assembler. Now that the CPU.

Sorry for bumping this, but hope it would be possible to explain some of the issues you have found with the assembler. I am interested in having a look at these so we can improve the situation.

Feb 8 2016, 6:53 AM

Dec 2 2015

jacob_hansen added a comment to rL254199: Revert Sparc and SparcV9 to external assembler. Now that the CPU.

Would it be possible to elaborate on the remaining issues for the Sparc integrated assembler? I had a look at bugzilla but could not find any references to issues with the integrated assembler for Sparc.

Dec 2 2015, 3:11 AM