This is an archive of the discontinued LLVM Phabricator instance.

[asan] Initialize __asan_set_shadow_* callbacks
ClosedPublic

Authored by vitalybuka on Aug 17 2016, 4:31 PM.

Diff Detail

Repository
rL LLVM

Event Timeline

vitalybuka updated this revision to Diff 68450.Aug 17 2016, 4:31 PM
vitalybuka retitled this revision from to [asan] Initialize __asan_set_shadow_* callbacks.
vitalybuka updated this object.
vitalybuka added reviewers: kcc, eugenis.
vitalybuka added a subscriber: llvm-commits.
eugenis edited edge metadata.Aug 17 2016, 5:42 PM

why do you want this change if the callbacks are not being used?
Dead code is bad.

test/Instrumentation/AddressSanitizer/stack-poisoning-experimental.ll
17 ↗(On Diff #68461)

does that actually do anything without a ":" after CHECK?

eugenis requested changes to this revision.Aug 17 2016, 5:44 PM
eugenis edited edge metadata.
This revision now requires changes to proceed.Aug 17 2016, 5:44 PM
vitalybuka marked an inline comment as done.Aug 17 2016, 5:49 PM

why do you want this change if the callbacks are not being used?

I am going to use in in future patches. This way we can have smaller reviews.

vitalybuka updated this revision to Diff 68466.Aug 17 2016, 5:53 PM
vitalybuka edited edge metadata.

fix in test

eugenis accepted this revision.Aug 18 2016, 10:58 AM
eugenis edited edge metadata.
This revision is now accepted and ready to land.Aug 18 2016, 10:58 AM
This revision was automatically updated to reflect the committed changes.