Make llvm-pdbdump print column info when available

[amccarth]

Summary

llvm-pdbdump already had code to retrieve column information in the line tables, but it wasn't using it.

Most Microsoft PDBs don't seem to have column info, so this wasn't missed. But Clang includes column info by default (at least for now), and being able to see that is useful for ensuring we get the column info correct.

I don't see many tests for llvm-pdbdump, so it's not obvious to me where or how a test for this should be written. Tested locally on a couple PDBs and noted that it gracefully displays line tables with and without column info.

[rnk]

lgtm w/ nit

tools/llvm-pdbdump/CompilandDumper.cpp

82 ↗

(On Diff #68428)

Indentation looks off

[amccarth]

Formatting fixed. (git clang-format isn't happy that my default version of Python is 3.x)

llvm/trunk/tools/llvm-pdbdump/CompilandDumper.cpp

while (auto File = Files->getNext()) {
         Printer << "Line ";
         PDB_ColorItem StatementColor = Line->isStatement()
                                            ? PDB_ColorItem::Keyword
                                            : PDB_ColorItem::LiteralValue;
         WithColor(Printer, StatementColor).get() << LineStart;
         if (LineStart != LineEnd)
           WithColor(Printer, StatementColor).get() << " - " << LineEnd;
 
+        uint32_t ColumnStart = Line->getColumnNumber();
+        uint32_t ColumnEnd = Line->getColumnNumberEnd();
+        if (ColumnStart != 0 || ColumnEnd != 0) {
+          Printer << ", Column: ";
+          WithColor(Printer, StatementColor).get() << ColumnStart;
+          if (ColumnEnd != ColumnStart)
+            WithColor(Printer, StatementColor).get() << " - " << ColumnEnd;
+        }
+
         Printer << ", Address: ";
         if (Line->getLength() > 0) {
           uint64_t AddrStart = Line->getVirtualAddress();
           uint64_t AddrEnd = AddrStart + Line->getLength() - 1;
           WithColor(Printer, PDB_ColorItem::Address).get()
               << "[" << format_hex(AddrStart, 10) << " - "
               << format_hex(AddrEnd, 10) << "]";
           Printer << " (" << Line->getLength() << " bytes)";