Page MenuHomePhabricator

[Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request)
ClosedPublic

Authored by faisalv on Aug 13 2016, 8:04 AM.

Details

Reviewers
hans
rsmith
Summary

Per Richard's request here:
https://llvm.org/bugs/show_bug.cgi?id=28366#c10

This patch essentially reverses all the changes from the following commit: https://reviews.llvm.org/rL264513 for the branch_3.9.

[This is my first time submitting 'pull requests' for a specific branch. I checked-out the respective release branches for llvm and clang, and reverted the above commit (resolved a conflict in the process) and created a patch. My box is currently still compiling and running regression tests (will update the revision within the next two hours if any revisions need to be made). Please let me know if I should be doing anything different]

Diff Detail

Event Timeline

faisalv updated this revision to Diff 67963.Aug 13 2016, 8:04 AM
faisalv retitled this revision from to [Branch 3.9] Remove any traces of partial constexpr lambda implementation (per Richard's request).
faisalv updated this object.
faisalv added reviewers: hans, rsmith.
faisalv added a subscriber: cfe-commits.

Everything compiles - and all tests in clang/test pass.

hans edited edge metadata.Aug 15 2016, 9:59 AM

[This is my first time submitting 'pull requests' for a specific branch. I checked-out the respective release branches for llvm and clang, and reverted the above commit (resolved a conflict in the process) and created a patch. My box is currently still compiling and running regression tests (will update the revision within the next two hours if any revisions need to be made). Please let me know if I should be doing anything different]

This looks good to me. I'd like Richard to stamp this before we commit, though.

Thanks,
Hans

rsmith accepted this revision.Aug 15 2016, 1:07 PM
rsmith edited edge metadata.
This revision is now accepted and ready to land.Aug 15 2016, 1:07 PM
hans added a comment.Aug 15 2016, 1:09 PM

Faisal: go ahead and commit directly to the branch, or let me know if you'd like me to do it.