This is an archive of the discontinued LLVM Phabricator instance.

[compiler-rt] Include windows.h with the right capitalization
AbandonedPublic

Authored by mstorsjo on Aug 9 2016, 3:56 AM.

Download Raw Diff

Details

Reviewers

Summary

This is an issue if cross-building for windows from a case sensitive
file system - the common spelling is with a lower case 'w'.

Diff Detail

Event Timeline

mstorsjo updated this revision to Diff 67315.Aug 9 2016, 3:56 AM

mstorsjo retitled this revision from to [compiler-rt] Include windows.h with the right capitalization.

mstorsjo updated this object.

mstorsjo added a reviewer: compnerd.

mstorsjo added a subscriber: llvm-commits.

Herald added a subscriber: dberris. · View Herald TranscriptAug 9 2016, 3:56 AM

The MS SDK however provides it with a capitalized name (at least in the recent SDKs). We should change the other case of the header name.

This revision now requires changes to proceed.Aug 9 2016, 7:53 AM

Hmm, indeed. I'll abandon this then.

Microsoft themselves aren't quite consistent with this within their own headers though; in the win10 sdk in the "um" subdirectory, they've got 470 cases of "#include <windows.h>" and 1 case of "#include <Windows.h>".

Revision Contents

Path

Size

lib/

builtins/

enable_execute_stack.c

2 lines

Diff 67315

lib/builtins/enable_execute_stack.c

	Show All 16 Lines
	/* #include "config.h"			/* #include "config.h"
	* FIXME: CMake - include when cmake system is ready.			* FIXME: CMake - include when cmake system is ready.
	* Remove #define HAVE_SYSCONF 1 line.			* Remove #define HAVE_SYSCONF 1 line.
	*/			*/
	#define HAVE_SYSCONF 1			#define HAVE_SYSCONF 1

	#ifdef _WIN32			#ifdef _WIN32
	#define WIN32_LEAN_AND_MEAN			#define WIN32_LEAN_AND_MEAN
	#include <Windows.h>			#include <windows.h>
	#else			#else
	#ifndef __APPLE__			#ifndef __APPLE__
	#include <unistd.h>			#include <unistd.h>
	#endif /* __APPLE__ */			#endif /* __APPLE__ */
	#endif /* _WIN32 */			#endif /* _WIN32 */

	#if __LP64__			#if __LP64__
	#define TRAMPOLINE_SIZE 48			#define TRAMPOLINE_SIZE 48
	Show All 39 Lines