The only difference between some tests is -offset passed to clang-rename. It makes sense to merge them into a single file and add multiple tool invocations.
Details
Details
Diff Detail
Diff Detail
- Repository
- rL LLVM
Event Timeline
Comment Actions
Awesome! A few improvements are still possible though. See inline comments.
test/clang-rename/ClassAsTemplateArgument.cpp | ||
---|---|---|
15 โ | (On Diff #66775) | Since clang-rename can output the result to stdout, it makes sense to avoid copying files and switch to a single pipeline for each test case. |
16 โ | (On Diff #66775) | Please add instruction on how to find offsets (something along the lines of "n-th line of grep -b Foo test-file.cpp"). |
Comment Actions
Rebased on master. Removed unneeded file copying etc since clang-rename can output to the stdout.